Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Answer m-lines should match offer m-lines even when answerer doesn't support media type #803

Closed
hassanctech opened this issue Sep 17, 2020 · 3 comments
Assignees

Comments

@hassanctech
Copy link
Contributor

Describe the bug
The master sample right now adds audio/video transceivers. If we modify it to only have video -- when replying to an offer which has recvonly audio, instead of sending an m-line it will send nothing.

Need to modify the logic that determines the response to match m-lines in offer even when local transceivers might not have matching media.

SDK version number
eac3e16 (latest)

Open source building

To Reproduce
Steps to reproduce the behavior:

  1. Modify master sample to have video only
  2. Run test page (https://awslabs.github.io/amazon-kinesis-video-streams-webrtc-sdk-js/examples/index.html) in Chrome and select audio and video
  3. Start master, and then start viewer
  4. See error about non-matching m-lines

Expected behavior
The answer (from the master side) should contain an m-line for audio but the direction can indicate it's not actually supported

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Browser Chrome
  • Version [e.g. 22]
@github-actions
Copy link

It looks like this issue has not been active for a long time. If the issue is not resolved, please add an update to the ticket, else it will be automatically resolved in a few days.

@disa6302
Copy link
Contributor

The work has not been initiated yet.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

This is a very old issue. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants