Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-sdk/client-quicksight is a dev dependency, causing build errors #195

Open
manueltarouca opened this issue Feb 22, 2024 · 0 comments
Open

Comments

@manueltarouca
Copy link

manueltarouca commented Feb 22, 2024

Issue

@aws-sdk/client-quicksight package currently sits as a dev dependency of this package. However when amazon-quicksight-embedding-sdk is added and imported into a project, for example an angular application, it raises an error stating that @aws-sdk/client-quicksight is nowhere to be found.

Temporary fixes

I've identified two alternatives for a fix:

  • tsconfig with compilerOptions's skipLibCheck set to true, however it can be a controversial change, due to removing the capacity of the typescript compiler identify possible type problems in the project dependencies.
  • Add @aws-sdk/client-quicksight to the project dependencies, however it adds an unnecessary dependency that should've been covered by amazon-quicksight-embedding-sdk.

Propose a fix

Yes

@manueltarouca manueltarouca changed the title @aws-sdk/client-quicksight should be a peer depedency @aws-sdk/client-quicksight is a dev dependency, causing build errors Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant