Skip to content

Commit

Permalink
fix(toolkit): stop 'cdk doctor' from printing AWS_ variables (#2357)
Browse files Browse the repository at this point in the history
Fixes #1931.
  • Loading branch information
rix0rrr authored Apr 23, 2019
1 parent 6c73d8a commit 6209c6b
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion packages/aws-cdk/lib/commands/doctor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function displayAwsEnvironmentVariables() {
}
print('ℹ️ AWS environment variables:');
for (const key of keys) {
print(` - ${colors.blue(key)} = ${colors.green(process.env[key]!)}`);
print(` - ${colors.blue(key)} = ${colors.green(anonymizeAwsVariable(key, process.env[key]!))}`);
}
return true;
}
Expand All @@ -68,3 +68,9 @@ function displayCdkEnvironmentVariables() {
}
return healthy;
}

function anonymizeAwsVariable(name: string, value: string) {
if (name === 'AWS_ACCESS_KEY_ID') { return value.substr(0, 4) + '<redacted>'; } // Show ASIA/AKIA key type, but hide identifier
if (name === 'AWS_SECRET_ACCESS_KEY' || name === 'AWS_SESSION_TOKEN') { return '<redacted>'; }
return value;
}

0 comments on commit 6209c6b

Please sign in to comment.