feat(s3): add MetricsConfiguration Property to S3 Bucket #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
requested changes
Apr 8, 2019
eladb
reviewed
Apr 11, 2019
| * | ||
| * @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket-metricsconfiguration.html | ||
| */ | ||
| readonly metricsConfigurations?: Array<CfnBucket.MetricsConfigurationProperty | cdk.Token> | cdk.Token; |
|
Thanks for your feedback! I reworked my commit and made it very similar to S3 Lifecycle Rules. @eladb suggested to use |
rix0rrr
reviewed
May 7, 2019
…rics
You can either specify the metrics as properties:
new Bucket(stack, 'Bucket', {
metrics: [{
id: "test",
tagFilters: {tagname1: "tagvalue1", tagname2: "tagvalue2"}
}]
});
Or use the `addMetric` function:
const bucket = new Bucket(stack, 'Bucket');
bucket.addMetric({
id: "test"
});
workeitel
force-pushed
the
s3-metrics-configuration
branch
from
b836ead to
349c966
Compare
|
updated docs and rebased on latest commit in |
rix0rrr
approved these changes
May 8, 2019
|
@workeitel looks great. Thanks for the contribution! |
SanderKnape
pushed a commit
to SanderKnape/aws-cdk
that referenced
this pull request
May 14, 2019
Add metric Property to S3 Bucket for configuring bucket metrics.
You can either specify the metrics as properties:
new Bucket(stack, 'Bucket', {
metrics: [{
id: "test",
tagFilters: {tagname1: "tagvalue1", tagname2: "tagvalue2"}
}]
});
Or use the `addMetric` function:
const bucket = new Bucket(stack, 'Bucket');
bucket.addMetric({
id: "test"
});
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.