-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add javascript for init-templates/sample-app #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
approved these changes
May 13, 2019
packages/aws-cdk/lib/init-templates/sample-app/javascript/.template.gitignore
Show resolved
Hide resolved
eladb
approved these changes
May 13, 2019
packages/aws-cdk/lib/init-templates/sample-app/javascript/README.md
Outdated
Show resolved
Hide resolved
Should you update README as well? |
@ozbillwang Which README? https://github.com/awslabs/aws-cdk/blob/master/README.md already mentioned JavaScript. |
No javascript list in
|
rix0rrr
approved these changes
May 20, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #398 and #2525
Many JavaScript developers still prefer working with JS files, this pull request added JavaScript support for init-templates/sample-app, utilizing following TypeScript features that enable the full power of TypeScript in JS files:
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.