Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): add metrics for Fargate service #2798

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jun 8, 2019

The BaseService class had a metric() implementation missing the ClusterName dimension (it was
overriden in Ec2Service with a correct implementation).

Moved correct metric(), metricCpuUtilization() and metricMemoryUtilization() methods to
BaseService. Both Ec2Service and FargateService now have correct metricXxx() methods.

Added tests for metricXxx() methods.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

The `BaseService` class had a `metric()` implementation missing the `clusterName` dimension (it was
overriden in `Ec2Service` with a correct implementation).

Moved correct `metric()`, `metricCpuUtilization()` and `metricMemoryUtilization()` methods to
`BaseService`. Both `Ec2Service` and `FargateService` now have correct `metricXxx()` methods.

Added tests for `metricXxx()` methods.
@jogold jogold requested review from SoManyHs and a team as code owners June 8, 2019 19:35
@rix0rrr rix0rrr merged commit acf015d into aws:master Jun 11, 2019
@jogold jogold deleted the fargate-metric branch June 11, 2019 12:35
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants