feat(sqs:large-message): Expose SDK v2 s3 client #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajagrawal16
changed the title
pankajagrawal16
force-pushed
the
issue-597
branch
from
2f446be
to
5db7fb9
Compare
pankajagrawal16
force-pushed
the
issue-597
branch
from
5db7fb9
to
a30360d
Compare
msailes
reviewed
Nov 5, 2021
| @@ -180,4 +180,31 @@ processing. | |||
| return "ok"; | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
| ## Passing custom S3Client | |||
There was a problem hiding this comment.
Consider a change to Overriding the default S3Client to match the method name.
msailes
reviewed
Nov 5, 2021
|
|
||
| ## Passing custom S3Client | ||
|
|
||
| If you need to pass custom S3Client such as region to the SDK, you can pass your own `S3Client` to be used by utility either for |
There was a problem hiding this comment.
Wording change.
"If you require customisations to the default S3Client, you can create your own S3Client and pass it to ......"
msailes
reviewed
Nov 5, 2021
msailes
reviewed
Nov 5, 2021
powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SqsUtils.java
Show resolved
Hide resolved
msailes
reviewed
Nov 5, 2021
powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SqsUtils.java
Outdated
Show resolved
Hide resolved
msailes
reviewed
Nov 5, 2021
powertools-sqs/src/main/java/software/amazon/payloadoffloading/PayloadS3Pointer.java
Show resolved
Hide resolved
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Issue #597
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.