Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): update version command to use lint-fix #1119

Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As reported in #1118 the version command present in the package.json files of all utilities is referencing another command (format) that has been renamed to lint-fix in a previous PR (#1105). This causes the release pipeline to fail.

This PR updates the content of the command from npm run format && git add -A src to npm run lint-fix && git add -A src (format becomes lint-fix).

How to verify this change

See diff, then check next run of the Make Release workflow.

Related issues, RFCs

Issue number: #1118

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Oct 17, 2022
@dreamorosi dreamorosi self-assigned this Oct 17, 2022
@dreamorosi dreamorosi linked an issue Oct 17, 2022 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2022
Copy link
Contributor

@ijemmy ijemmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreamorosi
Copy link
Contributor Author

Can you also apply the same on the idempotency folder?

https://github.com/awslabs/aws-lambda-powertools-typescript/blob/3b5c7994e2004e66cb16377190bbcac38003f9d0/packages/idempotency/package.json#L29

Done in the latest commit, thanks!

@dreamorosi dreamorosi requested a review from ijemmy October 17, 2022 10:01
@dreamorosi dreamorosi merged commit 6f14fb3 into main Oct 17, 2022
@dreamorosi dreamorosi deleted the 1118-bug-all-release-pipeline-fails-due-to-command-issue branch October 17, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: release pipeline fails due to command issue
2 participants