Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Clock Skew #213

Closed
kggilmer opened this issue Mar 4, 2021 · 10 comments · Fixed by smithy-lang/smithy-kotlin#972 or #1065
Closed

Handle Clock Skew #213

kggilmer opened this issue Mar 4, 2021 · 10 comments · Fixed by smithy-lang/smithy-kotlin#972 or #1065
Assignees
@lauzadis
Labels
feature-request A feature should be added or improved. no-auto-closure We do not want this issue to be automatically closed.

Comments

@kggilmer
Copy link
Contributor

kggilmer commented Mar 4, 2021

Some of the AWS SDK's (Java/C# for sure) handle local clock skew differences which can affect signing.

Something to keep in mind and look into. CRT may or may not already handle this IDK.

Some more context:
https://aws.amazon.com/blogs/developer/clock-skew-correction/

internal id: 173288088
@kggilmer
Copy link
Contributor Author

Verified w/ CRT team that there is nothing in CRT that currently would handle this for us.

@kggilmer
Copy link
Contributor Author

Java implementation: https://github.com/aws/aws-sdk-java-v2/blob/master/core/sdk-core/src/main/java/software/amazon/awssdk/core/retry/ClockSkew.java

@kggilmer
Copy link
Contributor Author

4 year old open customer request to add clock skew to BOTO3: boto/boto3#1252

@aajtodd
Copy link
Collaborator

aajtodd commented Jun 17, 2021

There was a recent issue in Amplify (or rather one of the lower level libs aws-sdk-android or aws-sdk-ios) regarding clock skew.

@kggilmer
Copy link
Contributor Author

Hmm, as in there as a problem with the SDK implementation? Or that iOS doesn't have the feature? (from searching it looks like both v1 and v2 java sdks have a clock skew feature)

@kggilmer
Copy link
Contributor Author

Spoke with people on java and .net teams regarding the perceived importance of the feature. Neither felt it was important to provide at GA.

@aajtodd
Copy link
Collaborator

aajtodd commented Jun 17, 2021

Spoke with people on java and .net teams regarding the perceived importance of the feature. Neither felt it was important to provide at GA.

Tend to agree, I don't think we have this slotted before then. Was just mentioning I saw an issue recently related to it, wasn't implying we should bump it up or anything.

@kggilmer
Copy link
Contributor Author

@normj's take:

I suspect the feature is a bit overkill now a days. The idea is client machines running the SDK might not be as strict with the time settings as servers so we added it. In reality who doesn't have their client machine's time automatically set from the internet. I think you are fine holding off till you get customer feedback asking for the feature.

There is also the small use case of when an AWS host for a service has a messed up time setting that we have compensated for that. I think that has happen once with S3 that I know of. But this is a small use case.

@aajtodd aajtodd transferred this issue from smithy-lang/smithy-kotlin Jul 8, 2021
@aajtodd aajtodd added the feature-request A feature should be added or improved. label Jul 8, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to provide a comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 2 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 2 days unless further comments are made. labels Jul 8, 2022
@ianbotsf ianbotsf added no-auto-closure We do not want this issue to be automatically closed. and removed closed-for-staleness labels Jul 11, 2022
@ianbotsf ianbotsf reopened this Jul 11, 2022
@ganeshnj ganeshnj mentioned this issue Oct 25, 2022
Open
2 tasks
@mattcreaser mattcreaser mentioned this issue Jul 27, 2023
Closed
1 task
@lauzadis lauzadis self-assigned this Oct 4, 2023
This was referenced Oct 6, 2023
Merged
Merged
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lauzadis lauzadis

Labels
feature-request A feature should be added or improved. no-auto-closure We do not want this issue to be automatically closed.
Projects
AWS SDK for Kotlin Public Roadmap
Status: Shipped
Milestone
No milestone
4 participants
@aajtodd @lauzadis @kggilmer @ianbotsf