Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of smithy-rules-engine for code generation #979

Closed
1 task
kstich opened this issue Jul 13, 2023 · 4 comments · Fixed by smithy-lang/smithy-kotlin#960 or #1052
Closed
1 task

Refactoring of smithy-rules-engine for code generation #979

kstich opened this issue Jul 13, 2023 · 4 comments · Fixed by smithy-lang/smithy-kotlin#960 or #1052
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@kstich
Copy link

kstich commented Jul 13, 2023

Describe the feature

The package smithy-rules-engine has undergone a major refactoring in an effort to improve validation, separate AWS and non-AWS concerns, add a specification, and better align with Smithy's coding standards. A code-stable pull request is available here. General notes are provided in individual commit messages. The format of the rules documents have not changed, meaning a successful migration to the refactored codebase will involve no changes to code generated for an SDK client.

The Smithy team plans to release this update on August 15th, 2023. Please reach out to us for any additional information or concerns.

Is your Feature Request related to a problem?

No.

Proposed Solution

No response

Describe alternative solutions or features you've considered

No response

Acknowledge

  • I may be able to implement this feature request

AWS Kotlin SDK version used

N/A

Platform (JVM/JS/Native)

N/A

Operating System and version

N/A

@kstich kstich added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 13, 2023
@ianbotsf ianbotsf self-assigned this Jul 17, 2023
@ianbotsf ianbotsf removed the needs-triage This issue or PR still needs to be triaged. label Jul 19, 2023
@kstich
Copy link
Author

kstich commented Aug 8, 2023

To account for upcoming traits to simplify the AWS endpoints modeling story for service teams, the AWS-specific components in this work have moved from smithy-aws-rules-engine to smithy-aws-endpoints. No other changes to the code within the package has been made.

To accomodate this change, we're pushing the planned release of the refactoring to August 22nd, 2023.

@cmoher
Copy link

cmoher commented Aug 18, 2023

The coordinated release is being pushed to 09/06. This does not change or impact the required changes for the SDKs.

@kstich
Copy link
Author

kstich commented Sep 5, 2023

The coordinated release of this refactoring has been delayed until 09/20.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants