You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Discussed with @jbelkins: pre-signed URLs are customizations we support for a select few operations & it is unnecessary to support types that are not needed.
This TODO was auto-generated. It is a suggestion to change an implementation based on the fact that we are not throwing an error in a test case and instead have actual logic. Deferring to the correctness of the implementation.
Describe the feature
The following TODOs can be removed as they are no longer necessary along with 1 small refactoring change
Use Case
We should address or remove all TODOs prior to GA.
Proposed Solution
Remove the following:
// TODO: remove once we have all the dependencies in the maven-publish plugin (build.gradle.kts, exclude(group = “brazil”))
// TODO: Subject to change when we figure out which strategy to use for XML // TODO: Subject to change if Foundation dependency is removed (XML Customizations)
// TODO ~ Implementation of embedded presigned URLs is TBD (PresignerGenerator.kt)
// TODO: We should support all types in our presignable operations
// TODO: add integration tests that automatically test that SSO crednetials provider correctly exchanges SSO token for temporary AWS credentails.
/// FIPS + path-only (TODO: consider making this an error) (EndpointResolverTest.swift)
Address the following small changes:
// TODO: move to proper location once we figure out where that should be
Other Information
Related Issue: #710
Acknowledgements
The text was updated successfully, but these errors were encountered: