You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In tests for restxml/xml-enums.smithy we currently tests structures, lists, nested lists, and enum lists, but do not tests sets and maps. The following comment was left in code found here:
// Todo: sets, maps
// 1. This will be part of: XmlEnumsInputOutput
// fooEnumSet: FooEnumSet,
// fooEnumMap: FooEnumMap,
//
// 2. Then add this:
// set FooEnumSet {
// member: FooEnum,
// }
//
// map FooEnumMap {
// key: String,
// value: FooEnum,
// }
//
Use Case
We should support sets and maps in smithy files sent over restxml protocol and therefore should also provide adequate test coverage of these scenarios.
Proposed Solution
Add test coverage and address any gaps in our implementation.
Is it possible that Smithy has added these as protocol tests in the restxml suite since the TODO was written?
(Such a test is not Swift-specific and I would expect it to be in the cross-platform protocol test suite if it is needed to ensure an implementation understands the protocol)
Describe the feature
In tests for restxml/xml-enums.smithy we currently tests structures, lists, nested lists, and enum lists, but do not tests sets and maps. The following comment was left in code found here:
Use Case
We should support sets and maps in smithy files sent over restxml protocol and therefore should also provide adequate test coverage of these scenarios.
Proposed Solution
Add test coverage and address any gaps in our implementation.
Other Information
Related issue: #710
Acknowledgements
The text was updated successfully, but these errors were encountered: