Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Region Resolver/Provider APIs #954

Closed
2 tasks
epau opened this issue Apr 12, 2023 · 3 comments
Closed
2 tasks

Clean up Region Resolver/Provider APIs #954

epau opened this issue Apr 12, 2023 · 3 comments
Assignees
Labels
feature-request A feature should be added or improved.
Milestone

Comments

@epau
Copy link
Contributor

epau commented Apr 12, 2023

Describe the feature

The APIs to resolve/provide a region are inconsistent with other similar constructs such as CredentialsProvider. We must clean up this API before going to GA to make it consistent with others.

Use Case

N/A

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@epau epau added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 12, 2023
@epau epau added this to the GA milestone Apr 12, 2023
@epau epau removed the needs-triage This issue or PR still needs to be triaged. label May 3, 2023
@epau
Copy link
Contributor Author

epau commented May 3, 2023

  • Look at SEPs to verify structure and API design
  • Make API consistent with other SDKs

@sichanyoo
Copy link
Contributor

There does not exist any SEP or SRA section outlining the region resolver API as of 1/9/2024. There's nothing to verify against other than other SDKs. Checked Kotlin and Rust SDKs and there does not exist a consistency among region resolving APIs.

However, SRA does outline credentials provider (identity resolver) API, which uses method name getIdentity. Following this, region provider / resolver API will be changed from resolveRegion to getRegion for consistency.

@jbelkins
Copy link
Contributor

Shipped in AWS SDK for Swift 0.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants