Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Standardize S3 Constructs): Match To Current Design Guidelines #485

Closed
2 tasks
biffgaut opened this issue Oct 28, 2021 · 1 comment
Closed
2 tasks
Assignees
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged

Comments

@biffgaut
Copy link
Contributor

biffgaut commented Oct 28, 2021

Over the past few months, upgrades to some S3 constructs have led to a richer S3 interface in the AWS Solutions Constructs design guidelines. This Issue is to drive a task to upgrade all S3 constructs to make them consistent and in agreement with the new design guidelines.

The updated design guidelines enable the construct to be totally cleaned up upon deletion - let's update all the unit tests to take advantage of that.

As each construct is completed, mark -done next to it below.

Constructs Affected:
aws-cloudfront-s3/ - done
aws-eventbridge-kinesisfirehose-s3/ - done
aws-events-rule-kinesisfirehose-s3/ - done
aws-iot-kinesisfirehose-s3/ - done
aws-kinesisfirehose-s3/ - done
aws-kinesisfirehose-s3-and-kinesisanalytics/ - done
aws-kinesisstreams-kinesisfirehose-s3/ - done
aws-iot-s3/
aws-lambda-s3/ - done
aws-s3-lambda/ - done
aws-s3-sqs/ - done
aws-s3-step-function/ - done
aws-s3-stepfunctions/ - done

Use Case

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@biffgaut
Copy link
Contributor Author

aws-iot-s3 is not published yet - checking this issue will be part of the approval process for that construct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants