feat(aws-alb-fargate): New Construct #560

biffgaut · 2021-12-29T22:19:05Z

Issue #, if available:
Closes #558

Description of changes:
New construct that launches an Application Load Balancer and Fargate Service

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aws-solutions-constructs-team · 2021-12-29T22:20:47Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 5ad29cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-29T22:20:48Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 5ad29cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-29T22:21:02Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 9b6e1b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-29T22:21:05Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 9b6e1b8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-29T22:33:36Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 7d38647
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-29T22:35:05Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 7d38647
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T00:32:45Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: d10eba7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T00:32:51Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: d10eba7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T00:57:11Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 02e06d3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T00:59:49Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 02e06d3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T16:30:12Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 805a4d3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T16:31:06Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 805a4d3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T16:44:32Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 132ad9e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T16:47:51Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 132ad9e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T19:15:40Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 85a2a8c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T19:16:09Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 85a2a8c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T19:26:32Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: c1b9989
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-12-30T19:29:27Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: c1b9989
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-04T21:28:55Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: fc04157
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-04T21:29:56Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: fc04157
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

hnishar · 2022-01-05T21:19:17Z

source/patterns/@aws-solutions-constructs/aws-alb-fargate/README.md

+        "arn:aws:acm:us-east-1:123456789012:certificate/11112222-3333-1234-1234-123456789012"
+      );
+
+  const props: AlbToLambdaProps = {


typo AlbToLambdaProps

hnishar · 2022-01-05T22:13:13Z

source/patterns/@aws-solutions-constructs/aws-alb-fargate/README.md

@@ -0,0 +1,113 @@
+# aws-alb-fargate module


Do you think we owe customers any guidance on why and when do they use this pattern -vs- a similar L3 pattern built by the ECS service team & published in the CDK repo ApplicationLoadBalancedFargateService ?

I don't think so - people looking at this probably already know the paradigm of solutions constructs.

hnishar · 2022-01-05T22:31:26Z

source/patterns/@aws-solutions-constructs/aws-alb-fargate/lib/index.ts

+   *
+   * @default - none
+   */
+  readonly existingFargateServiceObject?: ecs.FargateService;


Does it have to be an Object or can it support an Interface? IFargateService

Right now it could probably be the interface - but we're just scratching the service of the container ecosystem and can't see very far into the future. 6-12 months from now we can go back and change this to IFargateService without it being a breaking change. If we go with the interface now and find out in the future we need to use the object we would have to make a breaking change.

hnishar · 2022-01-06T00:53:21Z

source/patterns/@aws-solutions-constructs/core/lib/fargate-defaults.ts

+export function DefaultFargateServiceProps(
+) {
+  return {
+    assignPublicIp: true,


Is this considered best practice default setting for Fargate? Shouldn't it be false by default since it is fronted by an ALB which can made private/public?

That's a good question - I will look into it further.

hnishar · 2022-01-06T01:16:15Z

source/patterns/@aws-solutions-constructs/core/lib/fargate-defaults.ts

@@ -0,0 +1,58 @@
+/**


Are all these defaults derived from service documentation or vetted with any SME?

Met with 2 members of Containers TFC and adjusted values.

…s into Issue558

aws-solutions-constructs-team · 2022-01-07T14:29:58Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 58af74e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-07T14:30:30Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 58af74e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-07T14:56:13Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 730e838
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-07T14:56:35Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 730e838
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-07T16:06:08Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 273bb81
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-07T16:07:20Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 273bb81
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…s into Issue558

aws-solutions-constructs-team · 2022-01-07T16:59:52Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: abc4758
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-07T17:00:31Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: abc4758
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-07T17:13:18Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 42017cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-07T17:14:06Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 42017cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-08T01:26:07Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 8ff3d37
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-08T01:26:41Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 8ff3d37
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-08T14:43:07Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: e35eff2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-08T14:43:11Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: e35eff2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Initial push

5ad29cb

biffgaut requested review from hayesry and hnishar as code owners December 29, 2021 22:19

Merge branch 'main' into Issue558

9b6e1b8

viperlight updates

7d38647

accomodate merge from main

d10eba7

More Viperlight

02e06d3

Address cfn_nag issues

805a4d3

Viperlight Adjustments

132ad9e

Add a test that confirms the new Security Group code works

85a2a8c

Can't jump the gun on copyright year

c1b9989

Change SG Name to Description

94577e6

Merge branch 'main' into Issue558

fc04157

hnishar suggested changes Jan 6, 2022

View reviewed changes

biffgaut added 2 commits January 7, 2022 09:22

Address Review Comments

c0a893b

Merge branch 'Issue558' of github.com:awslabs/aws-solutions-construct…

58af74e

…s into Issue558

Merge branch 'main' into Issue558

730e838

Merge branch 'main' into Issue558

273bb81

biffgaut added 2 commits January 7, 2022 11:56

update copyright header

834d5a9

Merge branch 'Issue558' of github.com:awslabs/aws-solutions-construct…

abc4758

…s into Issue558

update copyright header

42017cb

Update defaults per TFC

8ff3d37

Add caveats surrounding internal HTTPS use

e35eff2

hnishar approved these changes Jan 8, 2022

View reviewed changes

biffgaut merged commit 5a21b76 into main Jan 8, 2022

biffgaut deleted the Issue558 branch January 8, 2022 16:10

feat(aws-alb-fargate): New Construct #560

feat(aws-alb-fargate): New Construct #560

Conversation

biffgaut commented Dec 29, 2021

aws-solutions-constructs-team commented Dec 29, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 29, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 29, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 29, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 29, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 29, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Dec 30, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 4, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 4, 2022

AWS CodeBuild CI Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 7, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 8, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 8, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 8, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 8, 2022