feat(README.md): add python and java minimal deployment #582

mickychetta · 2022-01-19T20:54:43Z

Issue #552 , if available:

Description of changes:
-Added Python minimal deployment
-Removed Initalizers

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

fixes #552

aws-solutions-constructs-team · 2022-01-19T21:02:04Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 4ca5cd1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-19T21:02:39Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 4ca5cd1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-19T23:01:16Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: aaeadc7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-19T23:02:08Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: aaeadc7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-19T23:30:24Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 886faff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-19T23:31:03Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 886faff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut

Stopped after a couple files so indents could be made consistent before I read the whole thing.

biffgaut · 2022-01-20T18:17:27Z

source/patterns/@aws-solutions-constructs/aws-alb-fargate/README.md

+
+# Obtain a pre-existing certificate from your account
+certificate = acm.Certificate.from_certificate_arn(
+      self,


This indent doesn't match the indent in the next function call (line 68). I know that indentions are important in Python ([sarcasm]one of the things I love so much about it[/sarcasm]), we should be consistent.

biffgaut · 2022-01-20T18:21:07Z

source/patterns/@aws-solutions-constructs/aws-alb-lambda/README.md

-      code: lambda.Code.fromAsset(`${__dirname}/lambda`),
-      runtime: lambda.Runtime.NODEJS_14_X,
-      handler: 'index.handler'
+        code: lambda.Code.fromAsset(`${__dirname}/lambda`),


These attributes should be indented 2. The only 4 space indent is multiple arguments for a function call.

aws-solutions-constructs-team · 2022-02-25T00:13:33Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: f62ade7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-02-25T00:14:08Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: f62ade7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…onstructs into 552

aws-solutions-constructs-team · 2022-02-25T22:08:35Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 279d872
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-02-25T22:09:19Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 279d872
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-02-25T22:21:24Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 36aad3f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-02-25T22:22:09Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 36aad3f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-02-28T19:12:53Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: d2a7961
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-22T22:34:36Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: aa3235e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-22T22:40:19Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 8b29c06
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-22T22:41:13Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 8b29c06
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-22T22:49:30Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: eae978f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-22T22:50:20Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: eae978f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut

Every V1 construct sample needs a comment (in the correct style for the language):

// aws-events-rule-lambda has been deprecated for CDK V2 in favor of aws-eventbridge-lambda.
// This sample uses the CDK V1 syntax

(the code block may not allow you to specify a link - if so, just leave off the link).

Beyond that, there are a few bugs in the Typescript samples mentioned.

source/patterns/@aws-solutions-constructs/aws-fargate-s3/README.md

source/patterns/@aws-solutions-constructs/aws-fargate-sns/README.md

source/patterns/@aws-solutions-constructs/aws-fargate-sqs/README.md

source/patterns/@aws-solutions-constructs/aws-kinesisfirehose-s3-and-kinesisanalytics/README.md

source/patterns/@aws-solutions-constructs/aws-lambda-sqs-lambda/README.md

source/patterns/@aws-solutions-constructs/aws-s3-stepfunctions/README.md

source/patterns/@aws-solutions-constructs/aws-events-rule-sqs/README.md

aws-solutions-constructs-team · 2022-03-29T18:33:36Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 747fee9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-29T18:34:02Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 747fee9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-29T18:43:13Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: c2b9177
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-29T18:43:46Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: c2b9177
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-29T18:58:50Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: b13e0f3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-29T18:59:47Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: b13e0f3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…onstructs into 552

aws-solutions-constructs-team · 2022-03-29T19:49:20Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: e3e738f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-29T19:49:31Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: e3e738f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-31T17:43:59Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 24e6778
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-31T17:44:01Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 24e6778
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut

One very minor change, then I think it is done!

biffgaut · 2022-03-31T17:18:58Z

source/patterns/@aws-solutions-constructs/aws-lambda-sqs-lambda/README.md

@@ -37,12 +37,12 @@ new LambdaToSqsToLambda(this, 'LambdaToSqsToLambdaPattern', {
  producerLambdaFunctionProps: {
      runtime: lambda.Runtime.NODEJS_14_X,
      handler: 'index.handler',
-      code: lambda.Code.fromAsset(`lambda/producer-function`)
+      code: lambda.Code.fromAsset(`producer-function`)


producer-lambda and consumer-lambda to match Python and Java examples

I realize this follows the terms in my original comment - sorry about that...

…nstructs into 552

aws-solutions-constructs-team · 2022-03-31T20:46:58Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 3087604
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-03-31T20:47:48Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 3087604
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mickychetta added 3 commits January 19, 2022 12:49

added python min deployment and removed initializers

7e002ef

pulled from main

ed641d6

fixed merge conflict

4ca5cd1

mickychetta requested review from biffgaut, hayesry and hnishar as code owners January 19, 2022 20:54

changed to v1 imports in deprecated constructs

aaeadc7

mickychetta self-assigned this Jan 19, 2022

added python min dep in new constructs

886faff

biffgaut previously approved these changes Jan 20, 2022

View reviewed changes

added java minimal deployment code

f62ade7

mickychetta dismissed biffgaut’s stale review via f62ade7 February 25, 2022 00:06

mickychetta added 2 commits February 25, 2022 11:59

Merge branch 'main' of https://github.com/mickychetta/aws-solutions-c…

f987485

…onstructs into 552

fixed java builder prop defintion

279d872

fixed indentation

36aad3f

Merge branch 'main' into 552

d2a7961

mickychetta requested a review from biffgaut February 28, 2022 19:05

added viperlight ignore to README with fake account numbers

8b29c06

added viperlight ignore to README with fake account numbers

eae978f

biffgaut requested changes Mar 27, 2022

View reviewed changes

added v1 deprecated comments in v1 constructs

747fee9

Merge branch 'main' into 552

c2b9177

Merge branch 'main' into 552

b13e0f3

Merge branch 'main' of https://github.com/mickychetta/aws-solutions-c…

e3e738f

…onstructs into 552

Merge branch 'main' into 552

24e6778

biffgaut requested changes Mar 31, 2022

View reviewed changes

mickychetta added 2 commits March 31, 2022 13:39

changed asset name in aws-lambda-sqs-lambda

3a7bff7

Merge branch '552' of https://github.com/mickychetta/aws-solutions-co…

3087604

…nstructs into 552

biffgaut approved these changes Mar 31, 2022

View reviewed changes

biffgaut merged commit 2ecd9dd into awslabs:main Mar 31, 2022

feat(README.md): add python and java minimal deployment #582

feat(README.md): add python and java minimal deployment #582

Conversation

mickychetta commented Jan 19, 2022

aws-solutions-constructs-team commented Jan 19, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 19, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 19, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 19, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 19, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 19, 2022

AWS CodeBuild CI Report

biffgaut left a comment

Choose a reason for hiding this comment

biffgaut Jan 20, 2022

Choose a reason for hiding this comment

biffgaut Jan 20, 2022

Choose a reason for hiding this comment

aws-solutions-constructs-team commented Feb 25, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Feb 25, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Feb 25, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Feb 25, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Feb 25, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Feb 25, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Feb 28, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 22, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 22, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 22, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 22, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 22, 2022

AWS CodeBuild CI Report

biffgaut left a comment

Choose a reason for hiding this comment

aws-solutions-constructs-team commented Mar 29, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 29, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 29, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 29, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 29, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 29, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 29, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 29, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 31, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 31, 2022

AWS CodeBuild CI Report

biffgaut left a comment

Choose a reason for hiding this comment

biffgaut Mar 31, 2022

Choose a reason for hiding this comment

biffgaut Mar 31, 2022

Choose a reason for hiding this comment

aws-solutions-constructs-team commented Mar 31, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Mar 31, 2022

AWS CodeBuild CI Report