Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RNN op generic #554

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Make RNN op generic #554

merged 1 commit into from
Feb 2, 2021

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Jan 21, 2021

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@stu1130 stu1130 requested review from frankfliu, roywei, zachgk and lanking520 and removed request for frankfliu January 21, 2021 23:27
@stu1130 stu1130 force-pushed the develop branch 8 times, most recently from 0dc6597 to 60adb14 Compare January 26, 2021 22:42
roywei
roywei reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to remove batch first option unless there is a solid usecase. Otherwise LGTM!

api/src/main/java/ai/djl/ndarray/internal/NDArrayEx.java Show resolved Hide resolved
api/src/main/java/ai/djl/nn/recurrent/RecurrentBlock.java Outdated Show resolved Hide resolved
roywei
roywei approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion with Jake offline, let's keep batchFirst option for potential speed ups by setting it to false, and set default value to true for ease of use.

@stu1130 stu1130 merged commit 5fbb6ce into deepjavalibrary:master Feb 2, 2021
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
@frankfliu
[python] Fixes typo in unit test (deepjavalibrary#554)
7b0a994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgk zachgk zachgk approved these changes

@roywei roywei roywei approved these changes

@frankfliu frankfliu Awaiting requested review from frankfliu

@lanking520 lanking520 Awaiting requested review from lanking520

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stu1130 @zachgk @roywei