Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non zero operator for PyTorch #704

Merged

Conversation

aksrajvanshi
Copy link
Contributor

Added nonzero operator for PyTorch. Added a Scalar check in JniUtils as PyTorch behaves differently in comparison to MXNet when passed a scalar value for nonzero operator.

Copy link
Contributor

@goswamig goswamig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add unit test ?

@frankfliu
Copy link
Contributor

LGTM, can we add unit test ?

We should already have coverage for this test case. We are testing all operators in Integration tests, If the engine throw UnsupportedOperationException, we just skip the test result.

@stu1130 stu1130 merged commit 4399dbc into deepjavalibrary:master Mar 2, 2021
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants