Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Allow roles to be specified for tasks and services #8

Closed
jpignata opened this issue Jan 3, 2018 · 7 comments
Closed

Allow roles to be specified for tasks and services #8

jpignata opened this issue Jan 3, 2018 · 7 comments
Assignees
Milestone

Comments

@jpignata
Copy link
Contributor

jpignata commented Jan 3, 2018

No description provided.

@jpignata jpignata self-assigned this Jan 3, 2018
@jpignata jpignata added this to the v0.3.0 milestone Jan 3, 2018
@jesseproudman
Copy link

Hi John!

We've got a Task Description that has a role pre-set, and when we update it with Fargate, that role gets lost. Is that the expected behavior? Seems like it should leave whatever role we had set, set but I'm not sure how it's stored on the AWS side.

@jpignata
Copy link
Contributor Author

Yeah, that'd be consistent with this issue. Each deploy is a new revision of the task definition, and my first cut didn't take into account task roles. I'll see if I can get this out prior to 0.3.0 in a quick fix. Sorry about that!

@jesseproudman
Copy link

No worries. I can't complain about bugs in OSS. :)

If you could get a fix out sooner rather than later, that'd be amazing. Every time we push code, it wipes that role which then breaks our deploy, so we're sorta stuck. Can work on a workaround if you think it'll be a bit though.

@jpignata
Copy link
Contributor Author

I'll get a fix out before the weekend is up.

@jesseproudman
Copy link

Excellent. Thanks John!

@jpignata
Copy link
Contributor Author

Fixed in 0.2.3.

@jesseproudman
Copy link

You rock!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants