Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsii-spec): Add optional metadata field #512

Merged
merged 4 commits into from
Jun 3, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Jun 3, 2019

This can be used to track free-form maintainer data, for use in systems that
are not part of the standard JSII toolchain. For example, it can be used to
encode configuration behavior for proprietary tools that process assemblies.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Certain targets (like `awsdocs`) do not require code generation or that
is not handled by `jsii-pacmak` itself. Instead of failing upon
discovering such targets in `package.json`, ignore them after printing
out a warning.
@eladb
Copy link
Contributor

eladb commented Jun 3, 2019

Why is "awsdocs" a jsii target if it's not a jsii target?

This can be used to track free-form maintainer data, for use in systems that
are not part of the standard JSII toolchain.
@RomainMuller RomainMuller changed the title feat(jsii-pacmak): Ignore "unsupported" targets feat(jsii-spec): Add optional metadata field Jun 3, 2019
@RomainMuller RomainMuller merged commit 10e2bfe into master Jun 3, 2019
@RomainMuller RomainMuller deleted the rmuller/ignore-bad-targets branch June 3, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants