Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Templating should skip commented out config #683

Open
4 of 6 tasks
mbevc1 opened this issue Dec 18, 2024 · 0 comments
Open
4 of 6 tasks

bug: Templating should skip commented out config #683

mbevc1 opened this issue Dec 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mbevc1
Copy link

mbevc1 commented Dec 18, 2024

Describe the bug
When commenting things out they still get processed by validation/pipeline run. For example account lookups still try to do lookups.

To Reproduce
Create an non-existing account lookup in the comments.

Expected behavior
Validation should skip commented out config.

Please complete the following information about the solution:

  • Version: [e.g. v1.11.0]

To get the version of the solution, you can look at the description of the created AWS CloudFormation stack used to install the LZA (AWSAccelerator-InstallerStack). For example, "(SO0199) Landing Zone Accelerator on AWS. Version 1.5.1.". If the description does not contain the version information, you can look at the Parameters of the stack for the RepositoryBranchName as that should contain the version number.

  • Region: [e.g. us-east-1]
  • Was the solution modified from the version published on this repository?
  • If the answer to the previous question was yes, are the changes available on GitHub?
  • Have you checked your service quotas for the services this solution uses?
  • Were there any errors in the CloudWatch Logs?

Screenshots
n/a

Additional context
n/a

@mbevc1 mbevc1 added the bug Something isn't working label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant