Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement file mtime,ctime,atime #35

Closed
dannycjones opened this issue Jan 5, 2023 · 1 comment · Fixed by #48
Closed

Implement file mtime,ctime,atime #35

dannycjones opened this issue Jan 5, 2023 · 1 comment · Fixed by #48
Assignees
Labels
good first issue Good for newcomers

Comments

@dannycjones
Copy link
Contributor

dannycjones commented Jan 5, 2023

Today, all files have an 'mtime' or last modified time of 1st January 1970.

We should use the creation date of the object (LastModified) for the 'mtime' (last modified time). We may also want to use this value for 'ctime' (inode change time) and 'atime' (access time) as well, but not sure on this.

@dannycjones dannycjones added the good first issue Good for newcomers label Jan 5, 2023
@dannycjones dannycjones self-assigned this Jan 5, 2023
@andywarfield
Copy link

Setting all three times to be creation time is consistent with S3 semantics. We should make sure to document that we are effectively doing default noatime here. We've talked about the idea of having different modes/personalities for the connector in the future, so it might be worth thinking about how to structure this in a way that helps support that later.

@dannycjones dannycjones added this to the beta milestone Jan 13, 2023
@dannycjones dannycjones linked a pull request Jan 16, 2023 that will close this issue
@dannycjones dannycjones changed the title Use object's creation date for "mtime" Implement file mtime,ctime,atime Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants