Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Propogate All Workspace status to DDB even if status is not a part of predefined mapping #1077

Open
ElenaKosobrodova opened this issue Dec 7, 2022 · 5 comments
Labels
closing-soon-if-no-response Ask for response from requester, will close issue in 7 days if no response enhancement New feature or request Review One Review Two

Comments

@ElenaKosobrodova
Copy link

ElenaKosobrodova commented Dec 7, 2022

Describe the bug
Once Sagemaker Notebook instance is stopped, the user cannot start it again in SWB UI. The workspace status changes to Inactive and the Start button is inactive as well.

When the workspace status is Unknown in SWB UI, the same workspace has status STARTING_FAILED in EnvironmentsSc DynamoDB table. I suspect that there is some kind of mapping and STARTING_FAILED status is not a part of it. For example, COMPLETED status in DynamoDB corresponds to Available in SWB UI.

To Reproduce

  1. Start a new Workspace with Sagemaker Notebook instance
  2. Stop the instance
  3. Try to re-start it

Expected behavior
Unknown status should not appear in SWB UI.

Screenshots
image

Versions (please complete the following information):

  • Release Version installed [e.g. v1.0.3]

Additional context
Add any other context about the problem here.

@ElenaKosobrodova ElenaKosobrodova added the bug Something isn't working label Dec 7, 2022
@maghirardelli
Copy link
Contributor

Hello! Thanks for your report. This is the expected behavior of SWB to display Unknown for the statuses that are not necessarily meaningful to users. Is your request that the UI reflect "Starting Failed" instead?

@Bingjiling
Copy link
Contributor

Hi @ElenaKosobrodova ,

Thanks for reaching out! If the SageMaker instance fail to re-start, the UI would show Unknown status. This is a behavior by design, as we do not expect the UI to deal with different types of erroring out status of an instance. Could you please check the SageMaker instance in question through AWS Console and see what status it's in?

Thanks,
Yanyu

@ElenaKosobrodova
Copy link
Author

Thank you for the fast response. I think for troubleshooting purposes it would be more useful to see the actual status instead of Unknown. But I understand that you didn't want to overload users with unnecessary information.

I checked Sagemaker console. The instance is stopped. I can start and stop it from the console, but workspace status remains Unknown. I could not replicate the issue with other instances yet.

@DA-Osborne
Copy link

I just thought I would add to this, we also get this randomly for workspaces. This will cause the dynamodb entry to become something service workbench does not recognise, and it displays 'Unknown', with no way for an end user to resolve themselves. Every time this happens, we get support tickets from the users. We then change the dynamodb entry to 'Stopped' again, and then they can start their instance normally. It would be great to modify this behavior so that it either reverts back to stopped by itself, or at least displays the actual status, with a 'reset' button to try and resolve this. Otherwise, it appears to the end users that our platform is buggy.

@nguyen102 nguyen102 changed the title [Bug] Workspace status is Unknown [Feature Request] Workspace status is Unknown Dec 20, 2022
@nguyen102 nguyen102 added enhancement New feature or request and removed bug Something isn't working labels Dec 20, 2022
@nguyen102 nguyen102 changed the title [Feature Request] Workspace status is Unknown [Feature Request] Propogate All Workspace status to DDB even if status is not a part of predefined mapping Dec 20, 2022
@nguyen102
Copy link
Contributor

I relabeled this issue as a feature request and added it to our backlog.

@kpark277 kpark277 added the closing-soon-if-no-response Ask for response from requester, will close issue in 7 days if no response label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing-soon-if-no-response Ask for response from requester, will close issue in 7 days if no response enhancement New feature or request Review One Review Two
Projects
None yet
Development

No branches or pull requests

6 participants