Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable crate reorganization for the SDK #2433

Merged
merged 14 commits into from
Mar 13, 2023

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Mar 4, 2023

Motivation and Context

This PR enables the client crate reorganization for the AWS SDK.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti added the breaking-change This will require a breaking change label Mar 4, 2023
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@jdisanti jdisanti force-pushed the jdisanti-flip-crate-reorg-for-sdk branch from 5575b05 to b7cac3f Compare March 9, 2023 22:32
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@jdisanti jdisanti force-pushed the jdisanti-flip-crate-reorg-for-sdk branch from e36f62b to 44e6bf9 Compare March 10, 2023 17:44
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

@jdisanti jdisanti marked this pull request as ready for review March 10, 2023 23:33
@jdisanti jdisanti requested review from a team as code owners March 10, 2023 23:33
@@ -517,7 +523,7 @@ default = ["v0.4.1"]
.collect(),
release: None,
},
release_tag: ReleaseTag::from_str("release-2022-07-26").unwrap(),
release_tag: ReleaseTag::from_str("release-2023-05-26").unwrap(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be release-2023-01-26?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this test, it needs to be a release tag after release-2023-01-26. The code will see that release-2023-01-26 < release-2023-05-26, and thus, add the release-2023-01-26 feature from the notable releases list.

@jdisanti jdisanti enabled auto-merge March 13, 2023 21:17
@jdisanti jdisanti disabled auto-merge March 13, 2023 21:53
@jdisanti jdisanti enabled auto-merge March 13, 2023 22:13
@jdisanti jdisanti added this pull request to the merge queue Mar 13, 2023
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python

A new doc preview is ready to view.

Merged via the queue into main with commit eb261e6 Mar 13, 2023
@jdisanti jdisanti deleted the jdisanti-flip-crate-reorg-for-sdk branch March 13, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants