You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here, we're not adding #[derive(Debug)] on the constrained shape ConstrainedList because containerDefaultMetadata(shape, model).derivesdoes not include Debug: indeed, SensitiveStructure does not #[derive(Debug)] because it implements Debug manually.
The text was updated successfully, but these errors were encountered:
)
Constrained shapes should always be able to `#[derive(Debug)]`.
Fixes#2582.
## Testing
The modified integration test fails without this patch applied.
## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
----
_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
Co-authored-by: Matteo Bigoi <1781140+crisidev@users.noreply.github.com>
)
Constrained shapes should always be able to `#[derive(Debug)]`.
Fixes#2582.
## Testing
The modified integration test fails without this patch applied.
## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
----
_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
Co-authored-by: Matteo Bigoi <1781140+crisidev@users.noreply.github.com>
Minimal reproducer:
Generates:
And so we get:
The mistake is around here:
https://github.com/awslabs/smithy-rs/blob/35f2f27a8380a1310c264a386e162cd9f2180137/codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ConstrainedShapeSymbolMetadataProvider.kt#L46-L48
Here, we're not adding
#[derive(Debug)]
on the constrained shapeConstrainedList
becausecontainerDefaultMetadata(shape, model).derives
does not includeDebug
: indeed,SensitiveStructure
does not#[derive(Debug)]
because it implementsDebug
manually.The text was updated successfully, but these errors were encountered: