Fix event streams in the orchestrator implementation #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
added
breaking-change
jdisanti
force-pushed
the
jdisanti-sra-eventstreams-2
branch
from
3e8671c
to
2545a01
Compare
|
Requesting server review since this breaking change will impact generated servers as well. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
May 8, 2023
Velfi
approved these changes
May 8, 2023
82marbag
approved these changes
May 11, 2023
jdisanti
force-pushed
the
jdisanti-sra-eventstreams-2
branch
from
2545a01
to
3ce420f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
force-pushed
the
jdisanti-sra-eventstreams-2
branch
from
3ce420f
to
fdedec6
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR gets event streams working in the client orchestrator implementation, and depends on #2671.
The orchestrator's
TypeErasedBoxenforces aSend + Syncrequirement on inputs and outputs. For the most part, this isn't an issue since almost all generated inputs/outputs areSend + Sync, but it turns out theEventStreamSenderwasn'tSyncdue to an omission of theSyncbound. Thus, this PR is a breaking change, as it adds aSyncrequirement for anyone who passes a stream to an event stream operation.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.