Add Scoped Plugin
#2759
Merged
Add Scoped Plugin
#2759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
force-pushed
the
harryb/scoped-plugin
branch
from
7a6efe2
to
264672c
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
force-pushed
the
harryb/scoped-plugin
branch
from
264672c
to
72133d7
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
approved these changes
Jun 13, 2023
| @@ -111,6 +111,8 @@ mod filter; | |||
| mod identity; | |||
| mod layer; | |||
| mod pipeline; | |||
| #[doc(hidden)] | |||
There was a problem hiding this comment.
I'd like Scoped and the scope macros to be the primary API and the #[doc(hidden)] items to be implementation details.
Co-authored-by: david-perez <d@vidp.dev>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
hlbarber
force-pushed
the
harryb/scoped-plugin
branch
4 times, most recently
from
fc7c8ea
to
f96e6ab
Compare
hlbarber
force-pushed
the
harryb/scoped-plugin
branch
from
4613440
to
8564c71
Compare
david-perez
reviewed
Jun 14, 2023
|
|
||
| /** Calculate all `operationShape`s contained within the `ServiceShape`. */ | ||
| private val index = TopDownIndex.of(codegenContext.model) | ||
| private val operations = index.getContainedOperations(codegenContext.serviceShape).toSortedSet(compareBy { it.id }) |
There was a problem hiding this comment.
Suggested change
| private val operations = index.getContainedOperations(codegenContext.serviceShape).toSortedSet(compareBy { it.id }) | |
| private val operations = index.getContainedOperations(codegenContext.serviceShape).toSortedSet(compareBy { it.id }) |
| "SmithyHttpServer" to ServerCargoDependency.smithyHttpServer(runtimeConfig).toType(), | ||
| ) | ||
|
|
||
| /** Calculate all `operationShape`s contained within the `ServiceShape`. */ |
There was a problem hiding this comment.
Suggested change
| /** Calculate all `operationShape`s contained within the `ServiceShape`. */ |
...n/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ScopeMacroGenerator.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ScopeMacroGenerator.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ScopeMacroGenerator.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ScopeMacroGenerator.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| fun render(writer: RustWriter) { | ||
| macro()(writer) |
There was a problem hiding this comment.
nit: I feel like you can just inline.
...n/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ScopeMacroGenerator.kt
Show resolved
Hide resolved
...n/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ScopeMacroGenerator.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: david-perez <d@vidp.dev>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
FilterByOperationNameallows the customer to filter application of a plugin. However this is a runtime filter. A faster and type safe alternative would be a nice option.Description
Add
ScopedPluginandscopemacro.