Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional auth in the orchestrator #2808

Merged
merged 11 commits into from
Jun 26, 2023
Merged

Fix optional auth in the orchestrator #2808

merged 11 commits into from
Jun 26, 2023

Conversation

jdisanti
Copy link
Collaborator

This PR:

  • Renames "anonymous auth" to "no auth"
  • Removes fallback to other auth schemes when an identity fails to resolve (this was not complying to the reference architecture)
  • Adds the ability to opt out of credentials in ConfigLoader, and removes defaulting of the shared credentials cache if no credentials provider is given
  • Makes ConfigBagAccessors work on FrozenLayer and CloneableLayer
  • Fixes STS and aws-config tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested review from a team as code owners June 24, 2023 00:24
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@jdisanti jdisanti requested a review from a team as a code owner June 26, 2023 20:38
@jdisanti jdisanti requested a review from unexge June 26, 2023 20:38
Velfi
Velfi approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@Velfi Velfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

jdisanti and others added 2 commits June 26, 2023 13:41
@jdisanti @Velfi
Update rust-runtime/aws-smithy-runtime-api/src/client/config_bag_acce…
c128e11 
…ssors.rs

Co-authored-by: Zelda Hessler <zhessler@amazon.com>
@jdisanti
Fix Typescript
f23dd8e
@jdisanti jdisanti requested a review from a team as a code owner June 26, 2023 21:40
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@aws-sdk-rust-ci aws-sdk-rust-ci merged commit 57459f0 into main Jun 26, 2023
40 of 41 checks passed
@aws-sdk-rust-ci aws-sdk-rust-ci deleted the jdisanti-sra-anonymous-auth branch June 26, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysaito1001 ysaito1001 ysaito1001 left review comments

@Velfi Velfi Velfi approved these changes

@unexge unexge Awaiting requested review from unexge unexge was automatically assigned from awslabs/smithy-rs-python-server

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdisanti @Velfi @ysaito1001 @aws-sdk-rust-ci