Re-point those using ByteStream and SdkBody to smithy-types
#3076
Conversation
ysaito1001
added
breaking-change
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
| "SmithyHttpServer" to ServerCargoDependency.smithyHttpServer(runtimeConfig).toType(), | ||
| "SmithyTypes" to RuntimeType.smithyTypes(runtimeConfig), |
There was a problem hiding this comment.
nit: I am not 100% sure on how .resolve works. But I am assuming, that is the way a type should be referred to in the code generator instead of hard coding it like #{SmithyTypes}::byte_stream::ByteStream, which is how we've done in streamingBodyTraitBounds.
So instead of SmithyTypes, if we keep "ByteStream" to RuntimeType.smithyTypes(rc).resolve("byte_stream::ByteStream") in the codegenScope do you think that would resolve into the same generated code?
There was a problem hiding this comment.
yeah that results in the same generated code
…tream-to-smithy-types
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
deleted the
ysaito/follow-up-on-moving-sdkbody-and-bytestream-to-smithy-types
branch
…#3091) ## Motivation and Context #3076 missed type alias for some types we moved to `aws-smithy-types`. This small PR will fix that. ## Testing Relied on the existing tests in CI ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Motivation and Context
A follow-up on #3026
Description
#3026 moved
aws_smithy_http::body::{BoxBody, Error, SdkBody}toaws_smithy_types::body::{BoxBody, Error, SdkBody}aws_smithy_http::byte_stream::{AggregatedBytes, ByteStream, error::Error}toaws_smithy_types::byte_stream::{AggregatedBytes, ByteStream, error::Error}and also left "breadcrumbs", so that customers could still consume updated types from
aws_smithy_httpafter the move.This PR turns breadcrumbs into deprecation messages (via
#[deprecated(...)]) and updates existing places that used to use moved types fromaws_smithy_httpto directly depend onaws_smithy_types.Testing
Relied on tests in CI.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.