Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Custom Auth Schemes were not respected #3087

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Oct 23, 2023

Motivation and Context

Description

Because AuthSchemeOptions were being registered at the operation level, there was no way for them to be overridden by customer-provided runtime plugins. This moves them into a separate plugin that is added at Client/Default priority.

Testing

  • new unit test

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested review from a team as code owners October 23, 2023 15:04
@rcoh rcoh changed the title Reproduce auth options issue Fix bug where Custom Auth Schemes were not respected Oct 23, 2023
@rcoh rcoh force-pushed the reproduce-auth-options-issue branch from b61aa99 to d9761d3 Compare October 23, 2023 20:34
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@@ -98,6 +99,171 @@ class HttpAuthDecoratorTest {
}
}

@Test
fun noAuthCustomAuth() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rcoh rcoh added the breaking-change This will require a breaking change label Oct 24, 2023
@rcoh
Copy link
Collaborator Author

rcoh commented Oct 24, 2023

not actually a breaking change but somehow broke the semver checker

@rcoh rcoh enabled auto-merge October 24, 2023 15:49
@github-actions
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

@rcoh rcoh added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 12bed90 Oct 24, 2023
40 of 41 checks passed
@rcoh rcoh deleted the reproduce-auth-options-issue branch October 24, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Authentication Scheme Issue
3 participants