Upgrade ring to 0.17.5 #3116
Merged
Upgrade ring to 0.17.5 #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
commented
Oct 31, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Oct 31, 2023
rcoh
pushed a commit
that referenced
this pull request
Nov 1, 2023
Fixes #3112. I opted to upgrade to the latest 0.17.5 in spite of the guidance in [RFC-21](https://github.com/awslabs/smithy-rs/blob/main/design/src/rfcs/rfc0021_dependency_versions.md) since this is a security critical dependency, and the maintainer has aggressively yanked old versions in the past. Note: ring 0.16 is still pulled in by rcgen as a dev dependency in aws-smithy-http-server-python after these changes. The rcgen crate hasn't upgraded yet. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3112.
I opted to upgrade to the latest 0.17.5 in spite of the guidance in RFC-21 since this is a security critical dependency, and the maintainer has aggressively yanked old versions in the past.
Note: ring 0.16 is still pulled in by rcgen as a dev dependency in aws-smithy-http-server-python after these changes. The rcgen crate hasn't upgraded yet.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.