Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default keepalive=false for fetch #1016

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 10, 2023

fixes aws/aws-sdk-js-v3#5334

sets fetch keepalive default to false.
keepalive for fetch has limitations in Chrome described in whatwg/fetch#679

@kuhe kuhe requested review from a team as code owners October 10, 2023 00:08
@kuhe kuhe force-pushed the fix/fetch-http-handler branch from e0fc76b to d86c798 Compare October 10, 2023 00:13
@kuhe kuhe force-pushed the fix/fetch-http-handler branch from d86c798 to 6af53e0 Compare October 10, 2023 14:43
@kuhe kuhe merged commit 34b7f7b into smithy-lang:main Oct 10, 2023
7 checks passed
@kuhe kuhe deleted the fix/fetch-http-handler branch October 10, 2023 15:37
hpmellema pushed a commit to hpmellema/smithy-typescript that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Failed to fetch
3 participants