Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operation index file codegen #1025

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Oct 11, 2023

Issue #, if available:

N/A.

Description of changes:

Fix operation index file codegen:

  • For services with no operations, export an empty module and use
    default service input/output types
  • Move operation index writing outside of operation loop

If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- For services with no operations, export an empty module and use
  default service input/output types
- Move operation index writing outside of operation loop
@syall syall marked this pull request as ready for review October 11, 2023 21:59
@syall syall requested review from a team as code owners October 11, 2023 21:59
@syall syall merged commit 3a5afa4 into smithy-lang:main Oct 11, 2023
7 checks passed
@syall syall deleted the fix-operation-index-file-codegen branch October 11, 2023 22:09
hpmellema pushed a commit to hpmellema/smithy-typescript that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants