Calculate content-length for SSDKs #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates SSDK generation so that content-length is properly calculated. The existing functionality for clients couldn't be re-used because it is designed to function as a middleware that runs just beforee the request is sent. That makes sense for the client, because a middleware could be modifying the body. But since the SSDK doesn't have middleware, we just embed it directly.
| + ".indexOf('content-length') === -1) {", "}", () -> { | ||
| writer.write("const length = calculateBodyLength(body);"); | ||
| writer.openBlock("if (length !== undefined) {", "}", () -> { | ||
| writer.write("headers = { ...headers, 'content-length': String(length) };"); |
There was a problem hiding this comment.
why do we reassign headers instead of mutating it?
There was a problem hiding this comment.
I based this off of what the client middleware plugin does. I'm not terribly attached to this approach though, so I can change it. @trivikr might have a stronger opinion
There was a problem hiding this comment.
The reassigning was done to usable immutability. We'd discovered a bug in during pre-GA because of mutation, which was fixed by using destructuring assignment
adamthom-amzn
approved these changes
Jul 19, 2021
trivikr
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates SSDK generation so that content-length is properly calculated. The existing functionality for clients couldn't be re-used because it is designed to function as a middleware that runs just before the request is sent. That makes sense for the client, because a middleware could be modifying the body. But since the SSDK doesn't have middleware, we just embed it directly.
Related PR that makes associated tests run once more (though they'll fail until this is merged): aws/aws-sdk-js-v3#2599
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.