Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use operation symbol name consistently #402

Merged

Conversation

JordonPhillips
Copy link
Contributor

This updates any usage of an operation name to go through the symbol provider. This avoids issues where the operation name's casing differs from that of the symbol.

Note: this has no impact on client generation, which already exclusively uses the symbol provider name.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This updates any usage of an operation name to go through the symbol
provider. This avoids issues where the operation name's casing
differs from that of the symbol.
@JordonPhillips JordonPhillips requested review from gosar and a team as code owners August 20, 2021 12:53
Copy link
Contributor

@gosar gosar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard without a diff of the generated code, but if you've tested against demo SSDK, the change LGTM.

@JordonPhillips JordonPhillips merged commit c800765 into smithy-lang:main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants