-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate protocol-specific event payload #554
generate protocol-specific event payload #554
Conversation
f2a2d92
to
1d4e1b2
Compare
Per discussing with @kstich, this PR doesn't handle the case where only a subset of members contains |
Address issue above in commit aws/aws-sdk-js-v3@ad2fa4e. The change excludes serializing the union or structure members with cc @kstich |
1d4e1b2
to
55af99c
Compare
...java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...java/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
Outdated
Show resolved
Hide resolved
* expose serializeInputEventDocumentPayload() to generate protocol-specific event payload * remove the event headers when serializing implicit event payload * address feedbacks
Issue #, if available:
The Lex-runtime-v2 service cannot serialzie the event correctly because the events without
eventHeader
oreventPayload
trait are not serialized, but returned as plain JavaScript object.For example:
TextEvent
is modeled as structure and serialized into a JavaScript Object(link).Description of changes:
This change expose a new interface
serializeInputEventDocumentPayload()
which generates the protocol-specific event payload. Specificly as mentioned in the Smithy spec:This change refactors the generator caused by the misunderstanding previously.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.