Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Record type in place of Object #557

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Jun 2, 2022

Issue #, if available:
Internal JS-3299

Description of changes:
Use Record type instead Object type.
Searched for regular expression \{ \[key: string\]: ([^ ]*) \} and replacing it with Record<string, $1>

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title Use Record type instead Object type Use Record type instead Object Jun 2, 2022
@trivikr trivikr changed the title Use Record type instead Object Use Record type in place of Object Jun 2, 2022
@trivikr trivikr marked this pull request as ready for review June 2, 2022 22:18
@trivikr trivikr requested a review from a team as a code owner June 2, 2022 22:18
@trivikr trivikr requested a review from AllanZhengYP June 2, 2022 23:08
@trivikr trivikr merged commit a5e1755 into smithy-lang:main Jun 3, 2022
@trivikr trivikr deleted the use-record-final branch June 3, 2022 05:00
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
* Use Record type instead Object type

* Update protocol-test-form-urlencoded-stub.ts

* Change Object -> Record in doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants