feat: allow non backward compatible required member #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardomourar
force-pushed
the
feat/non-backward-compatible-required-member
branch
from
d456dae to
f3bb827
Compare
srchase
reviewed
Jan 23, 2023
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java
Outdated
Show resolved
Hide resolved
srchase
approved these changes
Jan 23, 2023
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java
Outdated
Show resolved
Hide resolved
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java
Outdated
Show resolved
Hide resolved
srchase
suggested changes
Jan 23, 2023
...-codegen/src/test/java/software/amazon/smithy/typescript/codegen/StructureGeneratorTest.java
Outdated
Show resolved
Hide resolved
srchase
suggested changes
Jan 25, 2023
Can the overall PR description get updated with the enums and what impact each has on the generated code? |
srchase
previously approved these changes
Jan 31, 2023
syall
dismissed
srchase’s stale review
Decided to look into an alternative option.
srchase
suggested changes
Feb 1, 2023
gosar
reviewed
Feb 1, 2023
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java
Outdated
Show resolved
Hide resolved
gosar
reviewed
Feb 3, 2023
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/StructureGenerator.java
Outdated
Show resolved
Hide resolved
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java
Outdated
Show resolved
Hide resolved
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java
Outdated
Show resolved
Hide resolved
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java
Outdated
Show resolved
Hide resolved
...ript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptSettings.java
Outdated
Show resolved
Hide resolved
…/typescript/codegen/TypeScriptSettings.java Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
…/typescript/codegen/TypeScriptSettings.java Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
…/typescript/codegen/TypeScriptSettings.java Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
…/typescript/codegen/TypeScriptSettings.java Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
…/typescript/codegen/StructureGenerator.java Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
srchase
approved these changes
Feb 6, 2023
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* feat: allow non backward-compatible required member --------- Co-authored-by: Eduardo Rodrigues <eduardomourar@users.noreply.github.com> Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #503
Description of changes:
A continuation of PR #537, but we will allow to remove
| undefinedby setting an input configuration calledrequiredMemberModewith the following possible values:@requiredtrait applied to beundefined. By doing so it can still be considered a backwards compatible change for Smithy services even when the required constraint is dropped from a member .| undefinedfrom the generated code.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.