-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add packageDocumentation and improve interface inheritance #770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to put examples of the generated diffs in the PR description, and see if the output TypeScript compiles with the additional export statements and formatting?
...src/main/java/software/amazon/smithy/typescript/codegen/ServiceBareBonesClientGenerator.java
Show resolved
Hide resolved
...java/software/amazon/smithy/typescript/codegen/integration/AddBaseServiceExceptionClass.java
Show resolved
Hide resolved
See below for example diffs with suggested changes. I also ran Client
Command
Package Documentation
|
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.