Rename defaultClientConfiguration to defaultExtensionConfiguration #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
force-pushed
the
main
branch
6 times, most recently
from
b805825 to
daf8591
Compare
kuhe
reviewed
Aug 22, 2023
packages/smithy-client/src/extensions/defaultClientConfiguration.ts
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Aug 22, 2023
|
you would have to commit and publish the TS packages, and only afterward commit the java codegen and JSv3 codegen changes |
kuhe
approved these changes
Aug 22, 2023
syall
approved these changes
Aug 22, 2023
Comment on lines
21
to
27
| /** | ||
| * @deprecated use getDefaultExtensionConfiguration | ||
| * | ||
| * Helper function to resolve default extension configuration from runtime config | ||
| */ | ||
| export const getDefaultClientConfiguration = getDefaultExtensionConfiguration; |
There was a problem hiding this comment.
nit: should this still also be marked as @internal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.