Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow lowercase endpoint param #923

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix: allow lowercase endpoint param #923

merged 1 commit into from
Sep 8, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 8, 2023

fix to allow models to declare a param called endpoint with lowercase e.

All previously known AWS models had used Endpoint with uppercase E.

@kuhe kuhe requested review from a team as code owners September 8, 2023 16:19
@kuhe kuhe force-pushed the fix/lowercase-endpoint-param branch from 1f6d304 to f11924d Compare September 8, 2023 16:56
@syall syall merged commit 8e23b1b into smithy-lang:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddsriv siddsriv siddsriv approved these changes

@syall syall syall approved these changes

@trivikr trivikr trivikr approved these changes

@srchase srchase srchase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kuhe @srchase @trivikr @syall @siddsriv