Remove support for http prefix header maps of lists #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes support for binding the httpPrefixHeaders trait to a map with a value targeting a list of strings. This behavior isn't actually supported in practice by any client or server implementations. It is also extremely difficult to support not only because HTTP headers have no hard requirement on a common grammar (see Set-Cookie), but also because many HTTP cliens can't reliably control whether headers are sent in a single header field or across multiple header fields.
mtdowling
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes support for binding the httpPrefixHeaders trait
to a map with a value targeting a list of strings.
This behavior isn't actually supported in practice by any client
or server implementations. It is also extremely difficult to support
not only because HTTP headers have no hard requirement on a common
grammar (see Set-Cookie), but also because many HTTP cliens can't
reliably control whether headers are sent in a single header field
or across multiple header fields.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.