Add ability to serialize the JMESPath AST #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the JMESPath AST to be parsed, then modified, then reserialized. Use cases include things like being able to modify JMESPath expressions found in waiters so that field extraction matches any normalization changes code generators make to object keys (e.g., using snake_case in Ruby as opposed to the member names provided in the model).
JordonPhillips
approved these changes
Jan 18, 2022
smithy-jmespath/src/main/java/software/amazon/smithy/jmespath/ExpressionSerializer.java
Outdated
Show resolved
Hide resolved
|
Nice! |
…ExpressionSerializer.java Co-authored-by: Jordon Phillips <JordonPhillips@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the JMESPath AST to be parsed, then modified, then reserialized. Use cases include things like being able to modify
JMESPath expressions found in waiters so that field extraction matches any normalization changes code generators make to object keys (e.g., using snake_case in Ruby as opposed to the member names provided in the model).
To test, every valid expression from the jmespath test suite is parsed, serialized, and reparsed. The originally parsed AST is compared against the reparsed AST to ensure they are equal. Every JMESPath expression used in AWS waiters is included as a test case too.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.