Add getters and ability to copy settings between CodeWriters #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kggilmer
approved these changes
Jan 29, 2022
smithy-utils/src/main/java/software/amazon/smithy/utils/CodeWriter.java
Outdated
Show resolved
Hide resolved
It's sometimes useful to create other CodeWriters to do some work that uses the same settings as another CodeWriter. The `copySettingsFrom` method of CodeWriter takes another CodeWriter and copies its global and state settings into itself. This change also updates formatters registered with a CodeWriter to be per/state. This means that if a formatter is added in a specific state, then what that state is popped, the formatter is also removed and the CodeWriter returns to its original state. Closes #1066
mtdowling
force-pushed
the
codewriter-copy-state
branch
from
f27d6a1 to
3ca3861
Compare
JordonPhillips
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sometimes useful to create other CodeWriters to do some work that
uses the same settings as another CodeWriter. The
copySettingsFrommethod of CodeWriter takes another CodeWriter and copies its global and
state settings into itself.
This change also updates formatters registered with a CodeWriter to be
per/state. This means that if a formatter is added in a specific state,
then what that state is popped, the formatter is also removed and the
CodeWriter returns to its original state.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.