Enum shapes #1088
Merged
Enum shapes #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Feb 18, 2022
smithy-model/src/main/java/software/amazon/smithy/model/traits/EnumTrait.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/IntEnumShape.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/NamedMembers.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/EnumShape.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/IntEnumShape.java
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
idl-2.0
branch
from
3bac2d2 to
c47463e
Compare
This adds the enum shape java class and all the necessary code and traits to make it feasible. It doesn't do things like add parsing support or extensive updates to neighbor code.
This adds a validator for the enum shapes that ensures their members are corretcly set, that there's no duplicate values, and so on. In doing this a few changes had to be made in the enum classes themselves.
This deprecates the enum trait and updates all the internal enums to be enum shapes. It also fixes a few bugs along the way.
This make it a bit easier when all you care about is the name value pair.
JordonPhillips
force-pushed
the
enums-as-shapes-subclass
branch
from
4cc342a to
5dbad8b
Compare
mtdowling
requested changes
Feb 22, 2022
smithy-model/src/main/java/software/amazon/smithy/model/shapes/EnumShape.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/EnumShape.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/EnumShape.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/EnumShape.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/EnumShape.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/traits/EnumTrait.java
Outdated
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/traits/EnumDefinition.java
Outdated
Show resolved
Hide resolved
mtdowling
reviewed
Feb 24, 2022
smithy-model/src/main/java/software/amazon/smithy/model/traits/EnumValueTrait.java
Show resolved
Hide resolved
mtdowling
reviewed
Feb 25, 2022
smithy-model/src/main/java/software/amazon/smithy/model/transform/ModelTransformer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds enum shapes. Documentation will be part of a separate PR to keep this a bit smaller, but also because I'm still waiting on another review for #1073 which makes it hard to add new trait docs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.