Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about escaping backslash in pattern trait #1091

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Feb 14, 2022

Some customers have seen failures because of not escaping the backslash.

I added it as a Note, and after the existing Warning/Important.

This is what it would look like
Screen Shot 2022-02-14 at 11 56 35 AM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gosar gosar requested a review from a team as a code owner February 14, 2022 19:57
@gosar gosar merged commit e7a9528 into smithy-lang:main Feb 14, 2022
@gosar gosar deleted the backslash-regex branch February 14, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants