Update AWS protocol documentation #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
reviewed
Apr 5, 2022
|
|
||
| use aws.protocols#awsJson1_0 | ||
|
|
||
| @awsJson1_0(eventStreamHttp: ["h2"]) |
There was a problem hiding this comment.
Is this valid? The docs imply that http needs to be set if eventStreamHttp is set.
kstich
force-pushed
the
protocol_doc_updates
branch
from
3ab5005 to
91aaed3
Compare
kstich
force-pushed
the
protocol_doc_updates
branch
2 times, most recently
from
4360e06 to
79c92fc
Compare
This commit updates the awsJson1_0 and awsJson1_1 documentation to include their http and eventStreamHttp properties. These cannot be templated, because substitutions in code blocks aren't valid. Additionally, it removes a misleading note from the ec2Query docs.
kstich
force-pushed
the
protocol_doc_updates
branch
from
79c92fc to
0197714
Compare
mtdowling
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the awsJson1_0 and awsJson1_1 documentation
to include their http and eventStreamHttp properties. These cannot
be templated, because substitutions in code blocks aren't valid.
Additionally, it removes a misleading note from the ec2Query docs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.