Protocol tests applied to the wrong operations #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
jjant
added a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Oct 31, 2022
Marks these two tests as failing: - RestJsonWithPayloadExpectsImpliedContentType - RestJsonBodyMalformedMapNullKey These will be fixed in smithy-lang/smithy#1477.
jjant
added a commit
to smithy-lang/smithy-rs
that referenced
this pull request
Oct 31, 2022
* Add links to relevant issues/PRs for failing tests * Update codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/generators/protocol/ServerProtocolTestGenerator.kt Co-authored-by: david-perez <d@vidp.dev> * Make `build_router_and_make_request` return the response * Use `rustWriter.write` over `rustWriter.rust` for incomplete rust code * Run HttpMalformedRequest tests through router * Don't assert on operation_extension This causes HttpMalformedRequest tests to fail. * Refactor code to avoid repetition * Run ktlint * Check operation extension for regular request tests * Run ktlint * Remove unused parameter from `makeRequest` * Refactor checkRequest2 * Remove `checkRequest/2`, run new-style tests for malformed http requests - Remove `checkRequest`, `checkRequest2` in favour of using `makeRequest`/`makeRequest2` directly - Run service builder tests for MalformedHttpRequest tests * Format comment better * Remove `RestJsonStreamingTraitsRequireLengthWithBlob` from failing tests This test actually passes fine, but is not relevant for the server. * Add comment about `RestJsonHttpResponseCodeDefaultsToModeledCode` * Remove channel assertion on `makeRequest2` * Use `checkOperationExtension` for `makeRequest2` * Attempt to use a channel for both `makeRequest/2` * Go back to using channel for new api and operation extension for old api * Fix malformedHttpRequest tests * Add block around each API's tests * Remove unrelated file * Mark wrong tests as failing Marks these two tests as failing: - RestJsonWithPayloadExpectsImpliedContentType - RestJsonBodyMalformedMapNullKey These will be fixed in smithy-lang/smithy#1477. Co-authored-by: david-perez <d@vidp.dev>
sugmanue
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some tests are applied to the wrong operations.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.