Update protocol tests with datetime offset coverage #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the datetime specification mentions that UTC offsets are not allowed, they should be parsed gracefully and normalized to zero (no offset).
While the datetime specification mentions that UTC offsets are not allowed, they should be parsed gracefully and normalized to zero (no offset). These changes add tests to verify the correct serialization/deserialization behavior of both client and server protocol implementations.
srchase
approved these changes
Dec 7, 2022
AndrewFossAWS
approved these changes
Dec 7, 2022
Servers aren't expected to handle datetimes with offsets
srchase
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds a blurb about offsets for the protocol-
timestampFormattrait (specifically,date-time) for and adds the corresponding tests to verify the right behaviorsTesting
I generated and ran the client protocol tests in the Go-SDK, and then generated and ran the server protocol tests in the JS-SDK (only
RestJson1)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.