Fix return type of substring method #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
substring-return-type
branch
from
7fcd3a8 to
6402cde
Compare
rcoh
force-pushed
the
substring-return-type
branch
from
6402cde to
be4661b
Compare
kstich
reviewed
Nov 29, 2022
| public class RulesetTestUtil { | ||
| public static EndpointRuleSet loadRuleSet(String resourceId) { | ||
| InputStream is = RulesetTestUtil.class.getClassLoader().getResourceAsStream(resourceId); | ||
| assert is != null; |
There was a problem hiding this comment.
This can use the try-with-resources (try (InputStream is...) {) pattern to not need this assertion and also safely close the stream.
kstich
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: The type signature of the
substringendpoint method was incorrect—substring will returnNonewhen the resulting input string is shorter than the substring operation requires.This could lead to invalid rules being accepted by the rules engine.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.